Link to issue number:

Fixes #13372

Summary of the issue:

When rebuilding dist, some code changes were not detected. SCons does not trigger a new build.

Description of user facing changes

None

Description of development approach

dist will always be considered obsolete.

Testing strategy:

Test steps from #13372:

The following steps use scons launcher command but all the same applies to scons dist as well.

1. Get a fresh copy of NVDA:

> git clone --recursive https://github.com/nvaccess/nvda.git
> ...
> cd nvda

2. Build launcher:

> scons launcher
... many lines of actual building process omitted
scons: done building targets.

3. Check that launcher was built successfully:

> output\nvda_snapshot_source-master-6310b86.exe

4. Adding the following lines in core.py in def main right before app.MainLoop():

import tones
tones.beep(1000, 1000)

5. Running NVDA from source to make sure beep can be heard:

> runnvda.bat

6. Rebuild launcher:

> scons launcher
...
scons: `launcher' is up to date.
scons: done building targets.

Known issues with pull request:

It will always rebuild when building dist.

After running NVDA in the dist folder, encountered a Windows error during the rebuild. Speculating that py2exe is unable to replace the occupied file.
This issue, although not caused by this PR, should still be mentioned. See details in #15884.

There is no method found to only replace the modified files when rebuilding py2exe

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.