Again support WDAG in Microsoft Edge.#15810
Merged
Merged
Conversation
See test results for failed build of commit acefa5c4b4 |
Collaborator
|
Will this still work in the old case, i.e. when the remote WDAG UIA tree is parented into the local tree? |
Member
Author
|
@LeonarddeR Assuming the user is interacting with the WDAG process in the foreground (I.e. focus is inside it) then yes. Parenting has broken multiple times over WDAG's history in Windows. Thus this is a much safer, though slightly more limited option. |
Member
Author
|
It may be some time before the rangeFromChild bug is fixed in Windows. But merging this beforehand still provides some benefits for accessing WDAG anyway. |
seanbudd
approved these changes
Nov 26, 2023
Co-authored-by: Sean Budd <sean@nvaccess.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15164
Summary of the issue:
NVDA's support for Windows Defender Application Guard (WDAG) no longer workds as the requirement that the remote WDAG UIA tree be parented into the local tree under the main WDAG window is lon longer true. Thus it is impossible to find the local WDAG window and use this window handle for all WDAG NVDAObjects.
This means that NVA is essentially silent while focus is within a WDAG applcation.
Description of user facing changes
NVDA can again interact with applications such as Microsoft edge when run in Windows Defender Application Guard.
Description of development approach
Testing strategy:
Known issues with pull request:
Code Review Checklist: