Skip to content

Fix reporting of native Word commands to jump to table boundaries#15809

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:jumpEnd
Nov 22, 2023
Merged

Fix reporting of native Word commands to jump to table boundaries#15809
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:jumpEnd

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #15805

Summary of the issue:

In older versions of NVDA, NVDA was providing a speech feedback of the landing cell when using Word native commands for table navigation to jump to first or last cell of row or column: alt+home, alt+end, alt+pgUp and alt+pgDown. From NVDA 2023.2 onwards, this speech feedback is erroneous and reports the origin cell instead of the landing one. This is because the script for this commands was not robust and was taking advantage of existing delays in NVDA processing. in NVDA 2023.2 these delays have been reduced what uncovered this bug.

Description of user facing changes

The landing cell will be reported correctly again when using native Word table navigation to jump to first or last cell of row or column.

Description of development approach

Strategy inspired from #14984: send the gesture and check if the cursor location has changed before reporting its new position. If the cursor does not move, e.g. because you call a command to jumpt to first cell while you are already on the first cell, the current cell is reported after a maximum delay set to 0.15 seconds (same value as some other polling scripts).

Testing strategy:

Manual tests:

  • tested the 4 jumps commands when the cursor moves and when it does not move (because already on the target cell)
  • stress tested these commands keeping the shortcut pressed during a few seconds or calling different shortcuts in a quick sequence

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.
    Cc @LeonarddeR if you want to have a look since you are the author of Fix Excel cell reporting lagging behind #14984.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review November 21, 2023 15:49
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner November 21, 2023 15:49
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Nov 21, 2023

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

Comment thread source/NVDAObjects/IAccessible/winword.py
@seanbudd seanbudd merged commit 2214557 into nvaccess:master Nov 22, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Nov 22, 2023
@CyrilleB79 CyrilleB79 deleted the jumpEnd branch November 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MS Word - Commands to navigate to start or end of row or column do not report the correct cell anymore

3 participants