Use UIA for syslistview32 controls backed by Windows Forms#15799
Merged
seanbudd merged 9 commits intoNov 22, 2023
Conversation
Collaborator
Author
|
@beqabeqa473 Could you have a test of this? |
Contributor
|
Sure, i will test it in several hours. Thanks. |
Contributor
|
@LeonarddeR thanks, everything works as expected. |
michaelDCurran
requested changes
Nov 19, 2023
| # We need to rely on UIA for these controls, as otherwise parent/child navigation is broken. | ||
| # For other instances however, even when the control advertises a native UIA implementation, | ||
| # the implementation is likely to be incomplete and MSAA should be prefered. | ||
| return utils._isFrameworkIdWinForm(hwnd) |
Member
There was a problem hiding this comment.
I would like to see some logging either in or around this call, especially because it fetches a UIA element in order to check. Logging to say that it is going to check, and also logging the answer, as this is what then causes NvDA to decide if the window is native or not. See other examples of logging in this function.
lukaszgo1
reviewed
Nov 20, 2023
Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
seanbudd
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15283
Summary of the issue:
In Windows Forms applications, errors occur in list view controls.
Description of user facing changes
Win forms project in #15283 now works as expected for the most part.
Description of development approach
Rather than the previous approach where we removed the listing of SysListView32 from the list of bad UIA class names, this adds a specific utility function to checks for a Framework Id of WinForm. If that's the case, we use UIA for SysListView32, as it seems these implementations are mature enough.
Testing strategy:
Tested with the win forms project in #15283
Known issues with pull request:
None
Code Review Checklist: