more useful text content is shown in braille#15731
Conversation
|
As far as i know, this works, but shouldn't it check if the objects text info is NVDAObject text info, and if so, return False, because the NVDAObject text info is showing properties that will be shown in braille regardless? |
There is condition handling |
|
Ah you are actually correct. That puzzles me why this does not work automatically then. I'll investigate. |
|
I looked into the SASM editor, and there, |
|
@Emil-18 told that problem was in help window (when pressing f1). But are there more problems with sasm? One solution to this help window issue would be that |
|
The sasm help window can be read, but what if there are other instances of this problem where the control isn't read only? I also think it is better to check if obj is an instance of EditableTextBase, instead of checking if it is read only |
|
Thank you. When using
Why not use |
|
This should fix original issue. Do you think there are some side effects? |
LeonarddeR
left a comment
There was a problem hiding this comment.
This llooks good to me.
|
Thank you @LeonarddeR @Emil-18 do you agree? |
|
I agree |
|
It should solve #15755 also. |
|
As it is now, it doesn't solv #15755, because it is unrelated. The reason that NVDA don't update braille is because it thinks the two FakeTableCell objects is equal, and thus thinks it should move the review cursor instead of the navigator object. A way to solv it could be to implement _isEqual on FakeTableCell and return self.columnNumber == other.columNumber |
|
When using object navigation braille display was updated. But no problem, if you prefer, I remove that part. |
|
@burmancomp When you tested to see if #15755 was fixed, did you try to open the add-on store, focus on an add-on in the list, object navigate to the first child, and then object navigate to the next sibling? |
I suppose yes. I tested also with _isEqual, and it worked. |
|
@burmancomp Ok. After reviewing the code more thoroughly, I see why it works, but I don't think that is the best approach for fixing #15755, because FakeTableCell.basicText is equal to what the review cursor can read, and because of this, FakeTableCell objects has no reason to be reviewable in my opinion. Plus that the user has to scroll back to see information about role/column number/heading/etc. I am going to try to create a pull request that fixes #15755, but as of now, when I try to run scons.bat to run NVDA from source, I get the following output scons: warning: MSVC version '14.3' working host/target script was not found. |
|
I suppose your approach is better. I would recheck environment: https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/createDevEnvironment.md |
|
@burmancomp I am 99% sure that I have all dependencies. I am going to look at it again later to day. Could you test this, and see if it fixes #15755? |
|
You may need to do a |
|
@seanbudd I did that, but now I get this error instead |
|
I have also problems with visual studio 2022 environment. I have started discussion in nvda developers mailing list. I suggest you join to that list. I had also similar error, and error likely has something to do with spectre mitigation (related to some vulnerabilities I suppose). Installing spectre mitigation components seem to manage this error but what exactly should be installed, I do not know. Ensure with git status that there are no deleted files. If there are, undelete them. Maybe you are after that in the same situation with me. I am getting now error "LINK : fatal error LNK1104: cannot open file 'msvcprt.lib'" I have reported that error to developer list. I considered if some part/parts of environment might have references to visual studio 2019, and that error would be due to outdated references but this is just consideration. |
|
Please stop discussing a pr after it is merged. If there are any issues caused by a pr, a new issue should be opened instead. |
Link to issue number:
fixes #15605
Summary of the issue:
Although object contains useful text, and it is navigable with review cursor, all these objects are not handled as navigable objects in braille.
Description of user facing changes
Users who use merely braille can read content of more objects.
Description of development approach
Modified
braille.NVDAObjectHasUsefulTextfunction.Testing strategy:
Tested in sasm 3.14.0 editor help document.
Known issues with pull request:
none at this moment
Code Review Checklist: