NVDAObjects.UIA: fallback to known dialog class names if encountering a dialog despite UIA saying no#15730
Merged
seanbudd merged 3 commits intoNov 2, 2023
Conversation
… UIA itself says otherwise. Re nvaccess#15729. Some UIA windows such as Windows shutdown dialog are dialogs despite UIA saying they are not. Therefore, say 'False' when COM error is raised when obtaining UIA is dialog property, and if the property is indeed False, check UIA class name membership in known dialog class names.
seanbudd
approved these changes
Nov 2, 2023
Contributor
Author
|
Hi, Also performed lint (sorry for the late notice) - yep, findOverlayClasses is very complex. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15729
Summary of the issue:
NVDA does not announce dialog content for dialogs which UIA says no.
Description of user facing changes
NVDA will announce dialog content for more dialogs in Windows 10 and 11.
Description of development approach
Changed dialog detection in NVDAObjects.UIA by falling back to known class names if isDialog property says False.
Testing strategy:
Manual testing: type "shutdown /S /T 600" from PowerShell or Command Prompt with admin privileges and making sure NVDA announces dialog content.
Known issues with pull request:
None
Code Review Checklist: