winVersion: Deprecate Windows 7/8 constants#15669
Merged
seanbudd merged 7 commits intonvaccess:masterfrom Oct 23, 2023
Merged
Conversation
Deprecate winVersion.WIN7/WIN_SP1/WIN8 constants.
…s, replaced by defining it in getattr. Re nvaccess#15647. Only deal with 6.3 (Windows 8.1) and 10.0 (10/11) when fetching release name. As a replacement, provide release name field for deprecated Widnows release constants.
…es coming from getattr. Re nvaccess#15647
seanbudd
reviewed
Oct 23, 2023
user_docs/en/changes.t2t
Outdated
| - ``easeOfAccess.canConfigTerminateOnDesktopSwitch`` has been deprecated, as it became obsolete since Windows 7 is no longer supported. (#15644, @LeonarddeR) | ||
| - ``winVersion.isFullScreenMagnificationAvailable`` has been deprecated - use ``visionEnhancementProviders.screenCurtain.ScreenCurtainProvider.canStart`` instead. (#15664, @josephsl) | ||
| - The following Windows release constants has been deprecated from winVersion module (#15647, @josephsl): | ||
| - winVersion.WIN7 |
Member
There was a problem hiding this comment.
Please add code formatting for these
Suggested change
| - winVersion.WIN7 | |
| - ``winVersion.WIN7`` |
seanbudd
reviewed
Oct 23, 2023
seanbudd
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15647
Summary of the issue:
Deprecate Windows 7/8 constants and change release name fetcher process.
Description of user facing changes
None
Description of development approach
Edit winVersion module:
Testing strategy:
Manual testing and code coverage: the deprecated constants are removed from NVDA Core (try using Grep or similar tools) and documented in what's new document.
Known issues with pull request:
None
Code Review Checklist: