You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #13366 changed a way in which NVDA maps an app module to a given executable. In the process several old app modules were marked as deprecated (they show warnings on import). This is pretty noticeable when building developer documentation scons devDocs.
Description of user facing changes
None
Description of development approach
Deprecated app modules and supporting functions from appModuleHandler were removed. The app Module for Azardi which cannot be imported by Sphinx was renamed, and mapped to Azardi's binary.
Testing strategy:
Ensured that app module for Azardi is loaded. Ensured that warnings when building developer documentation are gone.
Known issues with pull request:
None known
Code Review Checklist:
Documentation:
Change log entry
User Documentation
Developer / Technical Documentation
Context sensitive help for GUI changes
Testing:
Unit tests
System (end to end) tests
Manual testing
UX of all users considered:
Speech
Braille
Low Vision
Different web browsers
Localization in other languages / culture than English
In the future, if there are appModules to rename, does it mean that it will not be allowed anymore to write deprecation code to map the old name to the new appModule? Or otherwise we would reintroduce #15618?
In the future, if there are appModules to rename, does it mean that it will not be allowed anymore to write deprecation code to map the old name to the new appModule? Or otherwise we would reintroduce #15618?
If name of old app module would be valid (i.e. would not contain characters such as + or .), then it should be possible to show deprecation warning on import only when not building developer documentation. DO you have a particular rename in mint?
No I do not have any appModule in mind.
I was just wondering if there was a risk that the issue comes back again in the future, and if (and how) we can mitigate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15618
Summary of the issue:
PR #13366 changed a way in which NVDA maps an app module to a given executable. In the process several old app modules were marked as deprecated (they show warnings on import). This is pretty noticeable when building developer documentation
scons devDocs.Description of user facing changes
None
Description of development approach
Deprecated app modules and supporting functions from
appModuleHandlerwere removed. The app Module for Azardi which cannot be imported by Sphinx was renamed, and mapped to Azardi's binary.Testing strategy:
Ensured that app module for Azardi is loaded. Ensured that warnings when building developer documentation are gone.
Known issues with pull request:
None known
Code Review Checklist: