Skip to content

Update braille and speak active cell and its content in MS Excel when UIA is not used and control+y, control+z or alt+backspace is pressed#15595

Merged
seanbudd merged 6 commits into
nvaccess:masterfrom
burmancomp:excel_updateBrailleWithRedoAndUndo
Oct 10, 2023
Merged

Conversation

@burmancomp

@burmancomp burmancomp commented Oct 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

fixes #15547

Summary of the issue:

When UIA is not used and control+y (redo), control+z / alt+backspace (undo) is pressed, braille is not updated and active cell and its content is not spoken.

Description of user facing changes

Braille is updated and active cell with its content is spoken.

Description of development approach

Added gestures control+y, control+z and alt+backspace to NVDAObjects.window.excel.ExcelWorksheet.script_changeSelection.

Testing strategy:

Tested with Albatross 80 and Excel 2019.

Known issues with pull request:

none at this moment

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@burmancomp burmancomp changed the title Update braille when UIA is not used and control+y, control+z or alt+backspace is pressed Update braille in MS Excel when UIA is not used and control+y, control+z or alt+backspace is pressed Oct 8, 2023
@AppVeyorBot

AppVeyorBot commented Oct 8, 2023

Copy link
Copy Markdown

See test results for failed build of commit 55a263a5cb

@burmancomp burmancomp changed the title Update braille in MS Excel when UIA is not used and control+y, control+z or alt+backspace is pressed Update braille and speak active cell and its contents in MS Excel when UIA is not used and control+y, control+z or alt+backspace is pressed Oct 9, 2023
@burmancomp burmancomp changed the title Update braille and speak active cell and its contents in MS Excel when UIA is not used and control+y, control+z or alt+backspace is pressed Update braille and speak active cell and its content in MS Excel when UIA is not used and control+y, control+z or alt+backspace is pressed Oct 9, 2023
@burmancomp burmancomp marked this pull request as ready for review October 9, 2023 07:29
@burmancomp burmancomp requested a review from a team as a code owner October 9, 2023 07:29
@burmancomp burmancomp requested a review from seanbudd October 9, 2023 07:29
seanbudd
seanbudd approved these changes Oct 9, 2023
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @burmancomp

seanbudd
seanbudd reviewed Oct 9, 2023
View reviewed changes
Comment thread user_docs/en/changes.t2t Outdated
@seanbudd seanbudd merged commit 88e5cf6 into nvaccess:master Oct 10, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 10, 2023
@burmancomp burmancomp deleted the excel_updateBrailleWithRedoAndUndo branch October 10, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.1

Development

Successfully merging this pull request may close these issues.

braille is not updated in excel when undoing

4 participants

@burmancomp @AppVeyorBot @seanbudd @nvaccessAuto