Restore old IA2 install/uninstall approach#15525
Merged
Merged
Conversation
michaelDCurran
approved these changes
Sep 26, 2023
Contributor
|
Confirmed that IA2 still works well with this PR on both Python 3.11 and 3.12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Replaces #15517
Summary of the issue:
It was pointed out by @michaelDCurran in #15517 (comment) that proxy registration in NVDA's main thread is essential.
Description of user facing changes
Probably nothing noticeable.
Description of development approach
Rename installIA2Support and uninstallIA2Support to installIA2SupportForThread and uninstallIA2SupportForTrhead, respectively. Introduce new installIA2Support and uninstallIA2Support wrappers that install/uninstall for the current thread. Also restored installation/uninstallation in NVDAHelper.py
Testing strategy:
Tested that installing and uninstalling works as no errors are generated.
Known issues with pull request:
None known
Code Review Checklist: