Skip to content

Add shortcut for audio panel#15497

Merged
seanbudd merged 11 commits into
betafrom
addShortCutForAudioPanel
Sep 25, 2023
Merged

Add shortcut for audio panel#15497
seanbudd merged 11 commits into
betafrom
addShortCutForAudioPanel

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Link to issue number:

Fixup of #15472

Summary of the issue:

A default gesture to open the new audio panel is desirable

Description of user facing changes

Adds nvda+ctrl+u as a command to open the audio panel

Commands for opening settings panels are now included in the key commands doc

Description of development approach

Adds nvda+ctrl+u as a command to open the audio panel

Adds keyCommands to the appveyor build for easier review of changes.

Updates to user guide

Testing strategy:

test using the command

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested review from a team as code owners September 22, 2023 05:07
@seanbudd seanbudd requested review from Qchristensen and michaelDCurran and removed request for a team September 22, 2023 05:07
@seanbudd seanbudd added this to the 2023.3 milestone Sep 22, 2023
@LeonarddeR

LeonarddeR commented Sep 22, 2023

Copy link
Copy Markdown
Collaborator

@seanbudd, given this is a fixup of #15472, I noticed that onOk of the SynthesizerSelectionDialog still has logic to reinitialize the tones module to update the audio device. Is this still required or may be an oversight?

@AppVeyorBot

AppVeyorBot commented Sep 22, 2023

Copy link
Copy Markdown

See test results for failed build of commit 734cad2ad4

@seanbudd

seanbudd commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

Apologies - it may be an oversight, however I'd keep it for safety in the beta.
Something to consider fixing in 2024.1

@AppVeyorBot

AppVeyorBot commented Sep 22, 2023

Copy link
Copy Markdown

See test results for failed build of commit a944a6681f

@LeonarddeR

LeonarddeR commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator

@seanbudd Could you please fix https://github.com/nvaccess/nvda/pull/15472/files#r1335020002 while at it?

michaelDCurran
michaelDCurran previously approved these changes Sep 25, 2023
View reviewed changes
@AppVeyorBot

AppVeyorBot commented Sep 25, 2023

Copy link
Copy Markdown

See test results for failed build of commit 094318c2a2

Qchristensen
Qchristensen previously approved these changes Sep 25, 2023
View reviewed changes

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, great work.

@AppVeyorBot

AppVeyorBot commented Sep 25, 2023

Copy link
Copy Markdown

See test results for failed build of commit 094318c2a2

@seanbudd seanbudd merged commit bf155e7 into beta Sep 25, 2023
@seanbudd seanbudd deleted the addShortCutForAudioPanel branch September 25, 2023 05:11
@CyrilleB79 CyrilleB79 mentioned this pull request Nov 9, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran left review comments

@Qchristensen Qchristensen Qchristensen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.3

Development

Successfully merging this pull request may close these issues.

5 participants

@seanbudd @LeonarddeR @AppVeyorBot @michaelDCurran @Qchristensen