Disable "Ignore blank lines" checkbox when report indent is off#15494
Merged
Conversation
seanbudd
reviewed
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up of #15057
Summary of the issue:
In the GUI, the recent trend is to disable (grey out) the options that are not applicable due to the values of other options.
New option "Ignore blank lines for line indentation reporting" has no sense when report indentation is OFF. Thus it should be greyed out when report indent is off.
This is especially needed to reduce the number of tab presses when navigating in the Doc formatting settings dialog which contains a lot of items.
Description of user facing changes
Option "Ignore blank lines for lineis greyed out when report indent is off and enabled when other indent reporting types are configured.
While at it, in this PR, I have also changed the context help target for "Ignore blank lines" option. Before it was jumping by default to "Document formatting settings" paragraph; now it jumps to "Line indentation reporting" paragraph, which contains more precise information on this topic.
Description of development approach
See code.
Testing strategy:
Manual tests:
Known issues with pull request:
Change log
Not needed: small change + applies to unreleased feature.
Code Review Checklist: