Skip to content

Disable "Ignore blank lines" checkbox when report indent is off#15494

Merged
seanbudd merged 4 commits into
nvaccess:betafrom
CyrilleB79:indentBlank
Sep 22, 2023
Merged

Disable "Ignore blank lines" checkbox when report indent is off#15494
seanbudd merged 4 commits into
nvaccess:betafrom
CyrilleB79:indentBlank

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Follow-up of #15057

Summary of the issue:

In the GUI, the recent trend is to disable (grey out) the options that are not applicable due to the values of other options.
New option "Ignore blank lines for line indentation reporting" has no sense when report indentation is OFF. Thus it should be greyed out when report indent is off.

This is especially needed to reduce the number of tab presses when navigating in the Doc formatting settings dialog which contains a lot of items.

Description of user facing changes

Option "Ignore blank lines for lineis greyed out when report indent is off and enabled when other indent reporting types are configured.

While at it, in this PR, I have also changed the context help target for "Ignore blank lines" option. Before it was jumping by default to "Document formatting settings" paragraph; now it jumps to "Line indentation reporting" paragraph, which contains more precise information on this topic.

Description of development approach

See code.

Testing strategy:

Manual tests:

  1. For each value of indent reporting:
  • Check that "Ignore blank lines..." is greyed out or not when opening doc formatting settings
  • Check that "Ignore blank lines..." is greyed out or not when changing the indent report mode in the combobox
  1. Check with appVeyor build the context help target.

Known issues with pull request:

  • In doc formatting settings, one may think that similar handling should be applied to table related options. But it should not instead. Because when using table nav commands, we can have coordinates reported even if tables are not reported (as a container)
  • I have not checked all the settings (and that's not suitable for a PR against beta); but there are other options in settings that may be greyed out depending on the value of another option. If there is a need for it, a new PR will be submitted.

Change log

Not needed: small change + applies to unreleased feature.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ready for review?

Comment thread source/gui/settingsDialogs.py Outdated
@seanbudd seanbudd added this to the 2023.3 milestone Sep 22, 2023
Comment thread source/gui/settingsDialogs.py Outdated
@seanbudd seanbudd marked this pull request as ready for review September 22, 2023 04:53
@seanbudd seanbudd requested a review from a team as a code owner September 22, 2023 04:53
@seanbudd seanbudd requested review from seanbudd and removed request for a team September 22, 2023 04:53
@seanbudd seanbudd merged commit f055abb into nvaccess:beta Sep 22, 2023
@CyrilleB79 CyrilleB79 deleted the indentBlank branch September 25, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants