Skip to content

beta to master#15487

Merged
seanbudd merged 1 commit into
masterfrom
beta
Sep 20, 2023
Merged

beta to master#15487
seanbudd merged 1 commit into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

Follow-up of #15472.

Summary of the issue:
If NVDA is started with WASAPI disabled in config and if you enable WASAPI, the new audio options to control NVDA sounds along with voice and volume of NVDA sound are available. That's confusing because modifying them will not have any effect until NVDA is restarted.

Description of user facing changes
Enabling or disabling audio options linked to WASAPI will be done looking at current state of WASAPI usage rather than looking at the state configured for next restart.

Also added an indication in the User Guide that these options can be unavailable so that the user does not look for them when they are greyed out.

Description of development approach
Rather than checking the config, check the player currently used to determine if the WASAPI related options need to be disabled or not.
@seanbudd seanbudd requested review from a team as code owners September 20, 2023 22:49
@seanbudd seanbudd merged commit 6ef664f into master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants