Skip to content

Add-on store: Clear download cache where appropriate#15471

Merged
seanbudd merged 2 commits into
betafrom
clearDLCache
Sep 20, 2023
Merged

Add-on store: Clear download cache where appropriate#15471
seanbudd merged 2 commits into
betafrom
clearDLCache

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 20, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15469

Summary of the issue:

Cancelled/failed downloads from the add-on store are not cleared.
This prevents future attempts at installation.

Description of user facing changes

Users should now be able to install add-ons after cancelling or if the download fails

Description of development approach

Clear the download cache:

  • when an add-on download fails/cancels
  • when exiting the store
  • when opening the store

Testing strategy:

Test cancelling and failing downloads. Ensure the status is reset and the add-on can be re-installed later

Known issues with pull request:

None

Change log entries:

Bug fixes

- Fixed bug where add-ons cannot be installed if a previous download failed or was cancelled. (#15469)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd added this to the 2023.3 milestone Sep 20, 2023
@seanbudd seanbudd requested a review from a team as a code owner September 20, 2023 00:55
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team September 20, 2023 00:55
michaelDCurran
michaelDCurran previously approved these changes Sep 20, 2023
@seanbudd seanbudd merged commit 0c00f6c into beta Sep 20, 2023
@seanbudd seanbudd deleted the clearDLCache branch September 20, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants