Skip to content

Fix more cases of grand child window focus failures#15455

Merged
seanbudd merged 3 commits into
nvaccess:betafrom
LeonarddeR:grandChildWindows
Sep 20, 2023
Merged

Fix more cases of grand child window focus failures#15455
seanbudd merged 3 commits into
nvaccess:betafrom
LeonarddeR:grandChildWindows

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator

Link to issue number:

Closes #15432

Summary of the issue:

Some events for grand child windows in applications seem to be ignored.

Description of user facing changes

Focus changes are reported in these cases.

Description of development approach

Generalize the workaround that was expanded for Edge in #15300

Testing strategy:

Known issues with pull request:

None known

Change log entries:

Bug fixes

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@josephsl

josephsl commented Sep 16, 2023 via email

Copy link
Copy Markdown
Contributor

@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

I don't know that issue, but if you could test drive it, that would be most helpful.

@seanbudd seanbudd added this to the 2023.3 milestone Sep 19, 2023
@seanbudd

Copy link
Copy Markdown
Member

Is this ready for review now that #15432 has been confirmed as fixed? It would be nice to get this into alpha for testing before a final beta3 early next week

@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

Sure, Go ahead.

@LeonarddeR LeonarddeR changed the title Try to work around more cases of grand child window focus failures Fix more cases of grand child window focus failures Sep 20, 2023
@seanbudd seanbudd marked this pull request as ready for review September 20, 2023 04:53
@seanbudd seanbudd requested a review from a team as a code owner September 20, 2023 04:53
@seanbudd seanbudd requested review from seanbudd and removed request for a team September 20, 2023 04:53
@seanbudd

Copy link
Copy Markdown
Member

any suggestions on a changelog entry?

@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

I just updated the initial description.

@seanbudd

Copy link
Copy Markdown
Member

Thanks

@seanbudd seanbudd merged commit 262b27c into nvaccess:beta Sep 20, 2023
@LeonarddeR LeonarddeR deleted the grandChildWindows branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants