Fix bug where NVDA would not speak until restarted after add-on installation.#15448
Conversation
|
@CyrilleB79 would you be able to confirm this build fixes #14525 |
|
@seanbudd, tests on the commit 8a16014 show that STR of #14525 is fixed. There is however a slightly different use case that remains problematic.
Actual behavior: Expected behavior: Note however that this issue is much more less concerning because we can imagine that people usually do not keep this dialog open. If you cannot find any fix for this, I'd suggest to merge the current PR anyway because it's already an improvement. |
|
@CyrilleB79 this should be fixed now |
Confirmed in beta branch: I get now the "Unavailable action" message after clicking Yes in the restart message. |
Link to issue number:
Fixes #14525
Summary of the issue:
NVDA blocks exit on modal dialogs which require an answer.
If a message box is created after NVDA has triggered a shutdown, NVDA blocks exit on the message box, even after synthesizers have been terminated.
Description of user facing changes
Fix bug where NVDA would not speak until restarted after add-on installation.
Similar bugs with the same root cause may also be fixed.
Description of development approach
Open, pending modal dialogs should block the exit of NVDA.
To prevent a deadlock NVDA should prevent opening new modal dialogs if the core shutdown has been triggered.
Testing strategy:
Test STR in #14525
Known issues with pull request:
None
Change log entries:
refer to diff
Code Review Checklist: