Skip to content

Fix issue with parsing version string when checking if add-on is force disabled#15444

Merged
seanbudd merged 1 commit into
betafrom
fix15440
Sep 14, 2023
Merged

Fix issue with parsing version string when checking if add-on is force disabled#15444
seanbudd merged 1 commit into
betafrom
fix15440

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 14, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15440
Fixup of #15402

Summary of the issue:

Some add-ons have version strings which we cannot parse for ordering.
When checking if an add-on should be force disabled, we don't handle the case where the version string cannot be parsed.
If a version string cannot be parsed, we should assume the add-on should not be force disabled, instead of throwing an error

Description of user facing changes

Add-ons which have unparsable version strings now work again

Description of development approach

If a version string cannot be parsed, we should assume the add-on should not be force disabled, instead of throwing an error

Testing strategy:

Test STR of #15440

Known issues with pull request:

Change log entries:

N/A unreleased regression

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 14, 2023 01:36
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team September 14, 2023 01:36
@seanbudd seanbudd added this to the 2023.3 milestone Sep 14, 2023
@michaelDCurran

Copy link
Copy Markdown
Member

In the pr description, multiple times you have:

we should assume the add-on should not be force disabled, rather throw an error

I assume you mean "rather than throw an error"?

@seanbudd

Copy link
Copy Markdown
Member Author

yes - fixed thanks

@seanbudd seanbudd merged commit 3cbafeb into beta Sep 14, 2023
@seanbudd seanbudd deleted the fix15440 branch September 14, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants