Conversation
Member
|
In the pr description, multiple times you have: I assume you mean "rather than throw an error"? |
michaelDCurran
approved these changes
Sep 14, 2023
Member
Author
|
yes - fixed thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15440
Fixup of #15402
Summary of the issue:
Some add-ons have version strings which we cannot parse for ordering.
When checking if an add-on should be force disabled, we don't handle the case where the version string cannot be parsed.
If a version string cannot be parsed, we should assume the add-on should not be force disabled, instead of throwing an error
Description of user facing changes
Add-ons which have unparsable version strings now work again
Description of development approach
If a version string cannot be parsed, we should assume the add-on should not be force disabled, instead of throwing an error
Testing strategy:
Test STR of #15440
Known issues with pull request:
Change log entries:
N/A unreleased regression
Code Review Checklist: