Force incompatibility for NVDAExtensionGlobalPlugin versions 12.0.8 or below#15443
Merged
Conversation
Contributor
Author
|
Note: the add-on has an integrated update system; so if the user has run NVDA since August and accepted the updates, he/she should not be impacted. Thus, @seanbudd let me know if you consider this PR justified or not. |
Member
|
Thanks for this, I think it's justified. |
seanbudd
previously approved these changes
Sep 14, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up of #15402
See #15402 (comment)
Summary of the issue:
As with Tony's Enhancements add-on, "NVDA global commands extension" add-on (name = NVDAExtensionGlobalPlugin) version 12.0.8 or below causes speech muted with WASAPI, so with NVDA 2023.3beta1.
This add-on is not in NVDA store but is popular in French community as well as in international community; it is translated in 10 languages.
A fix release (13.0) has already been created by the author @paulber19 on August 20. But we cannot ensure that people will have updated before updating NVDA.
Description of user facing changes
No problem when running NVDA with NVDAExtensionGlobalPlugin 12.0.8: NVDA is speaking.
Description of development approach
Added this add-on and its version in the list to force incompatibility.
Testing strategy:
Before coding the fix:
After coding the fix:
Known issues with pull request:
This fix should be removed for 2024.1 as it was done with Tony's add-on.
This should be done resolving the merge conflict that will occur when merging beta to master.
Change log entries:
New features
Changes
Replace:
Note: WASAPI is incompatible with version 1.51 and older of Tony's enhancement add-on. (#15402)(or similar)with:
Note: WASAPI is incompatible with some add-ons (Tony's Enhancements version 1.15 or older, NVDA global commands extension 12.0.8 or older). If you have such a version installed, it will be disabled. (#15402, #15443)Code Review Checklist: