Hi @hwf1324 - I forced pushed some changes to fix the underlying issue, rather than avoiding relying on our helper functions

@seanbudd why was it a problem to avoid using NVDA's helper functions? Everywhere in NVDA code base, NVDA does not use addLabeledControl but inserts directly the checkbox with addItem.

As #15426 (comment) indicates, please have a look at screen curtain warning dialog.

@CyrilleB79 - it's better to fix the root problem, otherwise other instances of trying to use the helper function to add a labelled checkbox would cause the same issue.

The support for checkboxes in the helper function was added recently, for the same convenience reasons that the helper function exists for other controls.
Older instances which use the more verbose method can always be converted later.

@hwf1324 - can you explain the reasoning for the changes you pushed?

@CyrilleB79 - it's better to fix the root problem, otherwise other instances of trying to use the helper function to add a labelled checkbox would cause the same issue.

The support for checkboxes in the helper function was added recently, for the same convenience reasons that the helper function exists for other controls. Older instances which use the more verbose method can always be converted later.

I do not know for which use case the support of checkbox in the helper function was added; it may be worth looking at it to understand if these are specific cases or not.

But on the contrary to combobox or edit field, wxPython's checkbox already implements the checkbox square and its label in the same control. Thus, there is no need to create a wx.Checkbox with no label and then associate our static text label thanks to our custom helper function. I feel that this encapsulation is more confusing.
The only case in which it can be useful is if you want to have the square located at the right of the label instead of having it located at its left as wx.Checkbox does.
Just my opinion though; the final decision is yours.

@hwf1324 - can you explain the reasoning for the changes you pushed?

@seanbudd, I'm not sure I understand what you mean.

My first thought was that it didn't match the look of the existing GUI interface, so I wanted them to be unified.

Then I found out through the "wxPython Widget Inspection Tool" that the checkbox is actually a combination of two controls.

For the mouse user, when they turn on the role of the object that reports what the mouse has moved to, the role for the StaticText control is just text, not a checkbox.

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/fn432hmciqr1y2xg/artifacts/output/nvda_snapshot_pr15434-29198,79faa1f2.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 24.5,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 22.6,
  FINISH_END 0.1

See test results for failed build of commit 79faa1f23d