Skip to content

Align horizontally checkbox in add-on store GUI#15428

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:alignCheckbox
Sep 12, 2023
Merged

Align horizontally checkbox in add-on store GUI#15428
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:alignCheckbox

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #15018

Summary of the issue:

In the add-on store, the "include incompatible add-ons" checkbox is not aligned with the combobox at its left.

Description of user facing changes

The checkbox will be aligned horizontally.

Description of development approach

In the guiHelper, added the wx.EXPAND flag so that it is centered vertically in the sizer.

I do not know if other items may benefit from this flag; we could add them in the if clause if / when needed in the future. such Horizontal sizers are less common in NVDA's GUI however.

Testing strategy:

Visual check.

Known issues with pull request:

None

Change log entries:

Not needed

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

@hwf1324 or @seanbudd, could you double check visually that the issue is fixed once the build is ready?

@CyrilleB79 CyrilleB79 marked this pull request as ready for review September 11, 2023 22:46
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner September 11, 2023 22:46
@CyrilleB79 CyrilleB79 requested a review from seanbudd September 11, 2023 22:46
@seanbudd seanbudd merged commit c46b3c9 into nvaccess:master Sep 12, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Sep 12, 2023
@seanbudd

Copy link
Copy Markdown
Member

Thanks @CyrilleB79

@CyrilleB79 CyrilleB79 deleted the alignCheckbox branch September 13, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add-on store GUI: The "Include incompatible add-ons" checkbox is not aligned with the component to its left, but rather it is affixed to the top.

3 participants