Align horizontally checkbox in add-on store GUI#15428
Merged
Merged
Conversation
Contributor
Author
Member
|
Thanks @CyrilleB79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15018
Summary of the issue:
In the add-on store, the "include incompatible add-ons" checkbox is not aligned with the combobox at its left.
Description of user facing changes
The checkbox will be aligned horizontally.
Description of development approach
In the guiHelper, added the wx.EXPAND flag so that it is centered vertically in the sizer.
I do not know if other items may benefit from this flag; we could add them in the if clause if / when needed in the future. such Horizontal sizers are less common in NVDA's GUI however.
Testing strategy:
Visual check.
Known issues with pull request:
None
Change log entries:
Not needed
Code Review Checklist: