Skip to content

Allow external install for already installed incompatible enabled add-on#15424

Merged
seanbudd merged 3 commits into
betafrom
fix-15417
Sep 11, 2023
Merged

Allow external install for already installed incompatible enabled add-on#15424
seanbudd merged 3 commits into
betafrom
fix-15417

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 11, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15417

Summary of the issue:

If an incompatible add-on is installed and currently enabled, you cannot install an incompatible add-on with the same ID using the external install feature.

Description of user facing changes

Allow external install for an already installed incompatible enabled add-on

Description of development approach

Only attempt to override the compatibility of an external install if this hasn't already been done

Testing strategy:

Test STR in #15417

Known issues with pull request:

None

Change log entries:

Bug fixes

  • Fix bug preventing incompatible add-ons which are installed and enabled being upgraded or replaced using the external install tool

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd added this to the 2023.3 milestone Sep 11, 2023
@seanbudd seanbudd requested a review from a team as a code owner September 11, 2023 07:04
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team September 11, 2023 07:04
michaelDCurran
michaelDCurran previously approved these changes Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants