Skip to content

Remove hack to disable tony's enhancements#15423

Merged
seanbudd merged 1 commit into
masterfrom
removeTonyHack
Sep 11, 2023
Merged

Remove hack to disable tony's enhancements#15423
seanbudd merged 1 commit into
masterfrom
removeTonyHack

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 11, 2023

Copy link
Copy Markdown
Member

Removes hack introduced in #15402

This removes the hack introduced for 2023.3 from 2024.1.
The hack in 2023.3 specifically recognises older versions of the add-on as incompatible.
The hack is not necessary with 2024.1, as the usual incompatibility warning applies when updating

@seanbudd seanbudd requested a review from a team as a code owner September 11, 2023 06:38
@CyrilleB79

Copy link
Copy Markdown
Contributor

Why this PR?

Especially given #15402 (comment):

Now that Tony's add-on seems to be fixed. Should this PR still be merged?

We think so, yes. This case when updating with an older version of this add-on installed is still really bad. I've removed some of the special handling (in regards to the warning message to disable WASAPI) as an updated version of the add-on is now available. While it is extremely frustrating when add-ons relying on the private functions hamper NVDA core development, it would be irresponsible of us to release 2023.3 knowing that many users will be upgrading to silence without an easy path to fix it.

Clarification is needed; thanks.

@seanbudd

Copy link
Copy Markdown
Member Author

This removes the hack introduced for 2023.3 from 2024.1.
The hack in 2023.3 specifically recognises older versions of the add-on as incompatible.
The hack is not necessary with 2024.1, as the usual incompatibility warning applies when updating

@seanbudd seanbudd merged commit 96224d2 into master Sep 11, 2023
@seanbudd seanbudd deleted the removeTonyHack branch September 11, 2023 09:54
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants