Conversation
michaelDCurran
previously approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15416
Summary of the issue:
When enabling/disabling an incompatible add-on, it is not filtered correctly when toggling filter by enabled/disabled status
Description of user facing changes
Fix bug described in #15416
Add-ons blocked due to compatibility reasons should now be filtered correctly when toggling the filter for enabled/disabled status.
Description of development approach
add additional checks for 'blocked' status when filtering enabled/disabled
Testing strategy:
Manually test disabling and enabling add-ons
Known issues with pull request:
None
Change log entries:
Bug fixes
Add-ons blocked due to compatibility reasons should now be filtered correctly when toggling the filter for enabled/disabled status. (#15416)
Code Review Checklist: