Skip to content

Fix link to coding standards document#15415

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
nvdaes:fixDocLink
Sep 11, 2023
Merged

Fix link to coding standards document#15415
seanbudd merged 1 commit into
nvaccess:masterfrom
nvdaes:fixDocLink

Conversation

@nvdaes

@nvdaes nvdaes commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

Link to issue number:

None. This is relatedto a broken link.

Summary of the issue:

The link to coding standards is broken in the contributing documentation.

Description of user facing changes

n/a

Description of development approach

n/a

Testing strategy:

n/a

Known issues with pull request:

None

Change log entries:

n/a

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@nvdaes nvdaes requested a review from a team as a code owner September 10, 2023 04:42
@nvdaes nvdaes requested a review from seanbudd September 10, 2023 04:42
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit c8fa9d139c

@nvdaes

nvdaes commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator Author

@Adriani90 , I've created this PR without an issue since this is related to a broken link, and the issue template for bug reports seems to be too complex for this. Please let me know if I should create an issue.

@CyrilleB79

Copy link
Copy Markdown
Contributor

@nvdaes, no problem: for small fixes, you do not need an associated PR.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes

@seanbudd seanbudd merged commit 628a9ee into nvaccess:master Sep 11, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants