Add checks for region updates#15393
Merged
Merged
Conversation
seanbudd
reviewed
Sep 8, 2023
seanbudd
reviewed
Sep 8, 2023
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15391
Fixup of #15163
Summary of the issue:
Since #15163, it is much more likely that braille tries to update a region for an object that no longer exists. This is no problem at all, however in that case, the region should simply be ignored for updating and a debug warning should be logged instead.
Description of user facing changes
No errors in de log while browsing
Description of development approach
a try/except around region.update, with an extra check to avoid updating regions for tree interceptors that have died.
Testing strategy:
Browsed with Firefox for some minutes, wasn't able to reproduce the issue any longer.
Known issues with pull request:
None known
Change log entries:
None needed
Code Review Checklist: