Skip to content

Add checks for region updates#15393

Merged
seanbudd merged 4 commits into
nvaccess:betafrom
LeonarddeR:isAlive
Sep 8, 2023
Merged

Add checks for region updates#15393
seanbudd merged 4 commits into
nvaccess:betafrom
LeonarddeR:isAlive

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #15391
Fixup of #15163

Summary of the issue:

Since #15163, it is much more likely that braille tries to update a region for an object that no longer exists. This is no problem at all, however in that case, the region should simply be ignored for updating and a debug warning should be logged instead.

Description of user facing changes

No errors in de log while browsing

Description of development approach

a try/except around region.update, with an extra check to avoid updating regions for tree interceptors that have died.

Testing strategy:

Browsed with Firefox for some minutes, wasn't able to reproduce the issue any longer.

Known issues with pull request:

None known

Change log entries:

None needed

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner September 7, 2023 10:10
@LeonarddeR LeonarddeR requested review from seanbudd and removed request for a team September 7, 2023 10:10
@seanbudd seanbudd added this to the 2023.3 milestone Sep 8, 2023
seanbudd
seanbudd previously approved these changes Sep 8, 2023

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @LeonarddeR

Comment thread source/braille.py
Comment thread source/braille.py Outdated
Co-authored-by: Sean Budd <seanbudd123@gmail.com>

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@seanbudd seanbudd merged commit 6b19080 into nvaccess:beta Sep 8, 2023
@LeonarddeR LeonarddeR deleted the isAlive branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants