Skip to content

Remove scheduled deprecations for 2024.1#15385

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:removeDeprecated
Sep 20, 2023
Merged

Remove scheduled deprecations for 2024.1#15385
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:removeDeprecated

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

Some braille related code was marked to be removed from NVDA 2024.1 (see changelog entries)

Description of user facing changes

None, as code is already written to be disabled in 2024.1.

Description of development approach

Removed the deprecated code.

Testing strategy:

  • Run from source with braille enabled.

Known issues with pull request:

None known

Change log entries:

Deprecations:

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 15547cec32

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 1034ff0e6e

@seanbudd seanbudd added this to the 2024.1 milestone Sep 7, 2023
@LeonarddeR LeonarddeR marked this pull request as ready for review September 11, 2023 16:25
@LeonarddeR LeonarddeR requested a review from a team as a code owner September 11, 2023 16:25
@LeonarddeR LeonarddeR requested a review from seanbudd September 11, 2023 16:25

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@seanbudd seanbudd merged commit d40caa1 into nvaccess:master Sep 20, 2023
@LeonarddeR LeonarddeR deleted the removeDeprecated branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants