Fix profile upgrade step for excluded displays#15371
Merged
Merged
Conversation
Signed-off-by: Leonard de Ruijter <L.de.Ruijter@sevenp.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15370
Summary of the issue:
The profile upgrade step for excluded displays can fail severely if keys don't exist in the profile.
Description of user facing changes
Crashes or upgrade failures no longer occur.
Description of development approach
Add extra checks for key existence.
Testing strategy:
Removed the auto section from the braille configuration and ensured that the profile upgrade was executed correctly on launch.
Known issues with pull request:
None known
Change log entries:
None needed
Code Review Checklist: