Fix WASAPI option enabling/disabling when restoring advanced options#15355
Merged
Conversation
See test results for failed build of commit d3ca497391 |
seanbudd
approved these changes
Sep 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None; fix-up of one of the recent WASAPI PRs.
Summary of the issue:
The following advanced options are greyed out or not depending if they are applicable: "Volume of NVDA sounds" and "Volume of NVDA sounds follows voice volume". If they are applicable or not depends on other options: "Use WASAPI for audio output" and "Volume of NVDA sounds" respectively. Unfortunately, when pressing the "Restore defaults" button of the advanced panel, the options are reset to there default values, but they are not greyed out / ungreyed accordingly.
Description of user facing changes
When pressing the restore default button in advanced panel, WASAPI advanced options will now be greyed out or not according to if they are applicable or not.
Description of development approach
Just call the update function
self._onWASAPIChange()when restoring the values.Testing strategy:
Manual tests
Known issues with pull request:
None
Change log entries:
Probably not needed for this small fix.
Code Review Checklist: