Skip to content

Fix WASAPI option enabling/disabling when restoring advanced options#15355

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:advOptions
Sep 3, 2023
Merged

Fix WASAPI option enabling/disabling when restoring advanced options#15355
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:advOptions

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None; fix-up of one of the recent WASAPI PRs.

Summary of the issue:

The following advanced options are greyed out or not depending if they are applicable: "Volume of NVDA sounds" and "Volume of NVDA sounds follows voice volume". If they are applicable or not depends on other options: "Use WASAPI for audio output" and "Volume of NVDA sounds" respectively. Unfortunately, when pressing the "Restore defaults" button of the advanced panel, the options are reset to there default values, but they are not greyed out / ungreyed accordingly.

Description of user facing changes

When pressing the restore default button in advanced panel, WASAPI advanced options will now be greyed out or not according to if they are applicable or not.

Description of development approach

Just call the update function self._onWASAPIChange() when restoring the values.

Testing strategy:

Manual tests

Known issues with pull request:

None

Change log entries:

Probably not needed for this small fix.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit d3ca497391

@CyrilleB79 CyrilleB79 marked this pull request as ready for review September 1, 2023 14:36
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner September 1, 2023 14:36
@CyrilleB79 CyrilleB79 requested a review from seanbudd September 1, 2023 14:36
@seanbudd seanbudd merged commit 404e316 into nvaccess:master Sep 3, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Sep 3, 2023
@CyrilleB79 CyrilleB79 deleted the advOptions branch September 4, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants