Fix-up of #15205: add deprecation information in the change log#15344
Merged
Conversation
See test results for failed build of commit 2738a0c827 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of #15205
Summary of the issue:
While addressing #15205 review, deprecation code has been added. However, I have forgotten to update the initial description's change log paragraph to mention it.
Description of user facing changes
Updated change log with deprecation information.
Note: a message will have to be sent to the API mailing list.
While at it:
Description of development approach
N/A
Testing strategy:
Check the html generated by appVeyor or locally.
Known issues with pull request:
None
Change log entries:
Object of this PR.
Code Review Checklist: