Skip to content

Fix-up of #15205: add deprecation information in the change log#15344

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:chgLog
Aug 30, 2023
Merged

Fix-up of #15205: add deprecation information in the change log#15344
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:chgLog

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of #15205

Summary of the issue:

While addressing #15205 review, deprecation code has been added. However, I have forgotten to update the initial description's change log paragraph to mention it.

Description of user facing changes

Updated change log with deprecation information.
Note: a message will have to be sent to the API mailing list.

While at it:

  • Added formatting to the previous item of the change log.
  • Fixed a missing end of list causing "Deprecation" paragraph title not being rendered correctly

Description of development approach

N/A

Testing strategy:

Check the html generated by appVeyor or locally.

Known issues with pull request:

None

Change log entries:

Object of this PR.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 2738a0c827

@CyrilleB79 CyrilleB79 marked this pull request as ready for review August 29, 2023 20:36
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner August 29, 2023 20:36
@CyrilleB79 CyrilleB79 requested a review from seanbudd August 29, 2023 20:36

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit d13398a into nvaccess:master Aug 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Aug 30, 2023
@CyrilleB79 CyrilleB79 deleted the chgLog branch August 31, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants