Implement tab navigation by Danstiv · Pull Request #15332 · nvaccess/nvda

Danstiv · 2023-08-25T18:32:14Z

Link to issue number:

#15046

Summary of the issue:

The lack of the ability to quickly switch to tabs complicates navigation

Description of user facing changes

Users will be able to switch between tabs in web documents, by assigning the appropriate gesture.

Description of development approach

Added another elif into _searchableAttribsForNodeType method in iaccessible, UIA and mshtml classes.
Added quick nav for tab navigation.

Testing strategy:

Manual

Assigned y / shift+y gestures to move between tabs.
Opened page with pull request creation form on github and pressed ctrl+home.
Pressed y, nvda announced "Write tab" and focused on it.
Pressed shift+y, NVDA announced "no previous tab", focus has not changed.
Pressed y, NVDA announced "Preview tab" and focused on it.
Pressed y, NVDA announced "no next tab", focus has not changed.
Pressed shift+y, nvda switched to previous Write tab back.

Known issues with pull request:

None

Change log entries:

New features
Added ability to quickly navigate through the tabs, the gestures are not set by default.
Changes
None
Bug fixes
None
For Developers
None

Code Review Checklist:

Pull Request description:
- description is up to date
- change log entries
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
API is compatible with existing add-ons.
Documentation:
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
Security precautions taken.

AppVeyorBot · 2023-08-25T19:56:51Z

PASS: Translation comments check.
PASS: Unit tests.
FAIL: Lint check. See test results for more information.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/kilon6086ga1r2mq/artifacts/output/nvda_snapshot_pr15332-28957,21b08ab2.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 0.9,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 25.5,
TESTSETUP_START 0.0,
TESTSETUP_END 0.3,
TEST_START 0.0,
TEST_END 23.9,
FINISH_END 0.1

See test results for failed build of commit 21b08ab2ec

seanbudd · 2023-08-28T01:33:55Z

Can you please add these gestures to the SingleLetterNavigation section of the user guide?

Danstiv · 2023-08-28T10:07:55Z

All done.

LeonarddeR · 2023-08-28T12:57:36Z

I'm afraid this pr is incomplete as is as it doesn't add support for UIA browse mode. Also mshtml isn't covered, thought that might be less relevant.

Also, personally I'd vote for leaving the tab quicknav gestures unassigned by default, as per a similar rationale as in #9227

Danstiv · 2023-08-28T15:14:30Z

personally I'd vote for leaving the tab quicknav gestures unassigned by default

Yes, that's probably a good idea.

Danstiv · 2023-08-28T15:17:28Z

Should unassigned gestures be documented somewhere?

LeonarddeR · 2023-08-28T16:01:29Z

That's a good point. They certainly deserve their space in the browsmode section, probably just below the assigned ones.

seanbudd

Looks good, just needs user guide documentation

Danstiv · 2023-08-29T14:40:27Z

just needs user guide documentation

As far as I understand, unassigned gestures are undocumented right now, so I think it's worth creating a new PR for this.
I am not ready to do this as my English is not good enough.

seanbudd · 2023-08-30T00:28:21Z

You are correct that this is the current norm, however as per #13024, it would be ideal to document these features in the user guide anyway. An unbound gesture should still be a documented feature in NVDA.

If you can write some basic documentation, we can help with expanding it, grammar, spelling and sentence structure.

Danstiv · 2023-08-30T10:27:29Z

Should these gestures be included in the Commands quick reference?

Danstiv · 2023-08-30T14:39:28Z

Why did it fail?

LeonarddeR · 2023-08-31T05:05:20Z

@Danstiv the system test failures are unrelated. CC @seanbudd

seanbudd · 2023-08-31T05:10:38Z

Should these gestures be included in the Commands quick reference?

I don't think so, but maybe? I'd like to see this discussed on #13024. Including key commands is done automatically with the macro kc:include.

Why did it fail?

Apologies, our test randomly fail due to the AppVeyor environment messing with focus. Don't worry about this issue.

seanbudd

Thanks for adding documentation. This generally looks good

AppVeyorBot · 2023-08-31T13:05:24Z

PASS: Translation comments check.
PASS: Unit tests.
FAIL: Lint check. See test results for more information.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/emb8esiutgsdw9r9/artifacts/output/nvda_snapshot_pr15332-29036,1f55146a.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 0.9,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 24.3,
TESTSETUP_START 0.0,
TESTSETUP_END 0.3,
TEST_START 0.0,
TEST_END 22.3,
FINISH_END 0.1

See test results for failed build of commit 1f55146aad

Qchristensen

Slight update to the user guide change, otherwise looks good.

Implement tab navigation

034877c

Danstiv marked this pull request as ready for review August 25, 2023 18:34

Danstiv requested a review from a team as a code owner August 25, 2023 18:34

Danstiv requested a review from seanbudd August 25, 2023 18:34

seanbudd reviewed Aug 28, 2023

View reviewed changes

Comment thread source/virtualBuffers/gecko_ia2.py Outdated

seanbudd marked this pull request as draft August 28, 2023 01:35

Danstiv added 2 commits August 28, 2023 14:41

Fix formatting

2648783

Document new gestures

64fbd86

Danstiv marked this pull request as ready for review August 28, 2023 10:08

Danstiv requested a review from a team as a code owner August 28, 2023 10:08

Danstiv requested a review from Qchristensen August 28, 2023 10:08

Danstiv added 2 commits August 28, 2023 21:54

Implement tab navigation in UIA browse mode

f4bb683

Implement tab navigation in mshtml browse mode

0e62efb

Danstiv marked this pull request as draft August 28, 2023 15:15

Remove default gesture

ed10191

Danstiv marked this pull request as ready for review August 28, 2023 16:26

seanbudd approved these changes Aug 28, 2023

View reviewed changes

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Aug 28, 2023

seanbudd marked this pull request as draft August 30, 2023 00:29

Document unassigned quick navigation gestures

4971854

Danstiv marked this pull request as ready for review August 30, 2023 11:34

This comment was marked as off-topic.

Sign in to view

LeonarddeR suggested changes Aug 31, 2023

View reviewed changes

Comment thread source/UIAHandler/browseMode.py Outdated

Comment thread user_docs/en/userGuide.t2t Outdated

seanbudd reviewed Aug 31, 2023

View reviewed changes

Comment thread user_docs/en/userGuide.t2t Outdated

Comment thread user_docs/en/userGuide.t2t Outdated

Comment thread user_docs/en/userGuide.t2t Outdated

Danstiv added 2 commits August 31, 2023 18:44

Refactor condition creation

7b6bf66

Rewrite and format Other navigation commands section in the userguide

32691bd

Danstiv marked this pull request as draft August 31, 2023 12:17

Danstiv marked this pull request as ready for review August 31, 2023 12:17

Fix code formatting

6c160f4

seanbudd approved these changes Sep 1, 2023

View reviewed changes

Qchristensen requested changes Sep 1, 2023

View reviewed changes

Comment thread user_docs/en/userGuide.t2t Outdated

seanbudd and others added 3 commits September 1, 2023 12:52

Update user_docs/en/userGuide.t2t

aa5a4e9

Merge remote-tracking branch 'origin/master' into tabNavigation

c00b88a

update hanges

9f660f9

seanbudd merged commit 128f683 into nvaccess:master Sep 1, 2023

nvaccessAuto added this to the 2023.3 milestone Sep 1, 2023

Adriani90 mentioned this pull request Dec 29, 2023

Additional Browse Mode Targets #15046

Closed

Uh oh!

Conversation

Danstiv commented Aug 25, 2023 • edited by seanbudd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Change log entries:

Code Review Checklist:

Uh oh!

AppVeyorBot commented Aug 25, 2023

Uh oh!

seanbudd commented Aug 28, 2023

Uh oh!

Uh oh!

Danstiv commented Aug 28, 2023

Uh oh!

LeonarddeR commented Aug 28, 2023

Uh oh!

Danstiv commented Aug 28, 2023

Uh oh!

Danstiv commented Aug 28, 2023

Uh oh!

LeonarddeR commented Aug 28, 2023 via email

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

Danstiv commented Aug 29, 2023

Uh oh!

seanbudd commented Aug 30, 2023

Uh oh!

Danstiv commented Aug 30, 2023

Uh oh!

This comment was marked as off-topic.

Danstiv commented Aug 30, 2023

Uh oh!

LeonarddeR commented Aug 31, 2023

Uh oh!

Uh oh!

Uh oh!

seanbudd commented Aug 31, 2023

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AppVeyorBot commented Aug 31, 2023

Uh oh!

Qchristensen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Danstiv commented Aug 25, 2023 •

edited by seanbudd

Loading