Remove bug template from blank issue template - was not kept in sync#15328
Merged
Conversation
See test results for failed build of commit 8f3cdcaa20 |
michaelDCurran
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the issue:
GitHub has an issue where even though we disable opening blank issues, they can still be created.
If a GitHub user reaches the page: https://github.com/nvaccess/nvda/issues/new,
.github/ISSUE_TEMPLATE.mdis rendered.It is uncertain where this page is linked from, as the preferred and main UX is where you choose an issue https://github.com/nvaccess/nvda/issues/new/choose.
An older copy of the issue template is kept in the blank issue template.
This is not kept in sync with the main bug report issue template.
It also misses a lot of information from the main bug report issue template.
Description of user facing changes
Remove the duplicate bug report template from the blank issue template.
Instead encourage using issue templates correctly.
More information on the GitHub bug
The bug with GitHub has been reported privately
The documentation for disabling blank issues is misleading - the behaviour of blank_issues_enabled could be improved further.
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
This is not true. A repository can always have a blank issue opened against it, regardless if blank_issues_enabled=false.
The url https://github.com/org/repo/issues/new is always accessible.
Instead it should redirect to https://github.com/org/repo/issues/new/choose if blank_issues_enabled=false.
Response from GitHub