Update triage docs - move from wiki#15327
Merged
Merged
Conversation
See test results for failed build of commit 98691e57eb |
Member
Author
|
cc @LeonarddeR |
LeonarddeR
reviewed
Aug 24, 2023
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for poking me. Here are my thoughts.
|
|
||
| For controversial changes, a product decision from NV Access may be required before applying the `triaged` label. This can be indicated with adding the label `blocked/needs-product-decision`. | ||
|
|
||
| ### Priority |
Collaborator
There was a problem hiding this comment.
I think it would really help to have a per priority break down of what happens when an issue with that priority pops up in several stages of development. Some random examples:
- P1: Indicates that the issue is serious enough that it has to be assigned to the milestone of the current beta release cycle (if any) or alpha otherwise. If a release has just been made, a hotfix should be considered
- P2, assigned to the milestone of current master cycle, pushed forward to next milestone when it is not feasible for the current
Etc. Etc.
Member
Author
There was a problem hiding this comment.
I think we will have to monitor the frequency of P2s to be able to determine what exactly we can commit to.
With limited capacity we can really only consider this a priority system.
With these new definitions we wanted to make maintaining 0 P1s more possible, by limiting the definition of a P1 further. We currently have many P1s that are rare/hard to reproduce issues.
Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com>
See test results for failed build of commit 8412e84695 |
Member
Author
|
@LeonarddeR - I've addressed your comments now |
See test results for failed build of commit 6ff383e6a2 |
michaelDCurran
approved these changes
Aug 28, 2023
See test results for failed build of commit acb1920164 |
seanbudd
commented
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the issue:
The triage docs are out of date.
Additionally, NV Access is intending to move most of the wiki into the repository, so changes are tracked better and easier to propose.
Description of user facing changes
The two triage wiki pages were merged into this one document:
A new section on issue labelling was created.
This adds more information into what makes an issue labelled as "triaged".
The section on the wiki on prioritization and p1,p2,p3,... labels was move to the labelling section.
The information here dated, and was not in line with how NV Access was labelling and prioritising.
We are also proposing new changes to the priority labelling with clearer definition boundaries.
The current p1-p4 issues will all be downgraded to p2-p5, with the exception of manually reviewed issues, and issues flagged by the community.
Additionally, some grammar and formatting fixes were made