Fix context menu bouncing in Edge browse mode#15316
Merged
Merged
Conversation
|
Using Microsoft Edge 116 with NVDA 2023.3 Beta 1, the context menu in the Edge history is still not accessible. |
Collaborator
Author
|
@Shah2 Please create a new issue for this. This pull request is closed. |
|
Now that I've updated to the latest alpha version, without the option to focus on elements when exploring in browse mode, I frequently see this error. I always have to focus on the link first before pressing shift + f10 so that it doesn't return to exploration mode. |
Member
|
@brunoprietog - please open a new issue for this. This pull request is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15309
Summary of the issue:
In Edge browse mode, when opening the context menu, NVDA many times goes back to browse mode.
Description of user facing changes
NVDA will no correctly focus the context menu opened from Edge browse mode.
Description of development approach
The issue behind this is as follows. Take a link as example:
Automatically set system focus to focusable elementsensures that an object only gets focus when strictly necessary. This is the case when opening the context menu, because otherwise, the context menu would open for the wrong object.There is a very trivial fix for this. With calling
api.processPendingEvents, we ensure that NVDA first processes the event generated by setFocus before executing the gesture.Testing strategy:
Tested the str from #15309
Known issues with pull request:
None known
Change log entries:
Bug fixes
Code Review Checklist: