Skip to content

MS Word object model: Always fetch range information#15307

Merged
seanbudd merged 3 commits into
masterfrom
fix-15019
Aug 21, 2023
Merged

MS Word object model: Always fetch range information#15307
seanbudd merged 3 commits into
masterfrom
fix-15019

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 18, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15019

Summary of the issue:

NVDA only fetches object text range information if "report headings" and "report comments and notes" are enabled.
This only happens when using the object model.
This causes a crash when attempting to update the caret, as we try to fetch range information that hasn't been generated by nvdaHelper.

Description of user facing changes

Fix crash in Microsoft Word when Document formatting options "report headings" and "report comments and notes" were not enabled.

Description of development approach

Always fetch range information, regardless of these options.

Testing strategy:

Test STR in #15019 with UIA and Object model

Known issues with pull request:

None

Change log entries:

Bug fixes
- Fix crash in Microsoft Word when Document formatting options "report headings" and "report comments and notes" were not enabled. (#15019)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner August 18, 2023 03:01
Comment thread nvdaHelper/remote/winword.cpp Outdated
@seanbudd seanbudd merged commit 755bfa7 into master Aug 21, 2023
@seanbudd seanbudd deleted the fix-15019 branch August 21, 2023 05:08
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unchecking "Report Comments" and "Report Titles" in the document formatting panel will cause ms word to crash and quit.

3 participants