Skip to content

Albatross: write timeout change and minor code refactoring#15269

Merged
seanbudd merged 6 commits into
nvaccess:masterfrom
burmancomp:albatrossWriteTimeoutAndMinorCodeRefactoring
Aug 22, 2023
Merged

Albatross: write timeout change and minor code refactoring#15269
seanbudd merged 6 commits into
nvaccess:masterfrom
burmancomp:albatrossWriteTimeoutAndMinorCodeRefactoring

Conversation

@burmancomp

Copy link
Copy Markdown
Contributor

Link to issue number:

none

Summary of the issue:

Driver used 0 for write_timeout (non-blocking). If display was updated frequently (for example pressing and holding arrow key down in long document), display updating continued some time after for example arrow key was not pressed anymore. Using write_timeout 0.2 seconds (quite typical value with other braille drivers) resolves this.

Description of user facing changes

Braille shows pretty quickly valid information after situations where braille line was updated frequently (for example when pressing and holding arrow key down in long document).

Description of development approach

In addition to write_timeout change, there is a change how display is updated after reconnection and exit from internal menu. Using braille.handler._displayWithCursor function, driver code can be reduced.

Testing strategy:

Tested with Albatross 80 model.

Known issues with pull request:

none known

Change log entries:

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@burmancomp burmancomp requested a review from a team as a code owner August 7, 2023 08:05
@burmancomp burmancomp requested a review from seanbudd August 7, 2023 08:05
Comment thread source/brailleDisplayDrivers/albatross/constants.py Outdated
Comment thread source/brailleDisplayDrivers/albatross/driver.py
@seanbudd seanbudd added the merge-early Merge Early in a developer cycle label Aug 18, 2023
@seanbudd seanbudd marked this pull request as draft August 21, 2023 06:41
@burmancomp burmancomp marked this pull request as ready for review August 21, 2023 08:40

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @burmancomp

@seanbudd seanbudd merged commit 7b6e071 into nvaccess:master Aug 22, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Aug 22, 2023
@burmancomp burmancomp deleted the albatrossWriteTimeoutAndMinorCodeRefactoring branch August 22, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-early Merge Early in a developer cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants