Conversation
michaelDCurran
approved these changes
Aug 4, 2023
See test results for failed build of commit 3b408a8db9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15257
Summary of the issue:
For an installed add-on the add-on store displays the help button, even if no help is available.
Description of user facing changes
Hide the help button if no help is available
Description of development approach
Fix typing and explicitly check if a help doc is available when determining if to display the help button
Testing strategy:
Test with the add-ons and STR in #15257
Known issues with pull request:
If there's no help available for the selected NVDA language or english, the help button will not be shown.
NVDA will not fallback to available languages or than english.
Change log entries:
N/A
Code Review Checklist: