Skip to content

Add-on store: don't show help button if not available#15259

Merged
seanbudd merged 1 commit into
betafrom
fixHelp
Aug 4, 2023
Merged

Add-on store: don't show help button if not available#15259
seanbudd merged 1 commit into
betafrom
fixHelp

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 4, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15257

Summary of the issue:

For an installed add-on the add-on store displays the help button, even if no help is available.

Description of user facing changes

Hide the help button if no help is available

Description of development approach

Fix typing and explicitly check if a help doc is available when determining if to display the help button

Testing strategy:

Test with the add-ons and STR in #15257

Known issues with pull request:

If there's no help available for the selected NVDA language or english, the help button will not be shown.
NVDA will not fallback to available languages or than english.

Change log entries:

N/A

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd added this to the 2023.2 milestone Aug 4, 2023
@seanbudd seanbudd requested a review from a team as a code owner August 4, 2023 02:49
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team August 4, 2023 02:49
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 3b408a8db9

@seanbudd seanbudd merged commit 836b6ef into beta Aug 4, 2023
@seanbudd seanbudd deleted the fixHelp branch August 4, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants