Add-on store: handle description from manifest is None#15245
Merged
Conversation
See test results for failed build of commit d9fecde090 |
michaelDCurran
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The description fields in the manifest are optional, and default to None.
This is not handled by the add-on models correctly, which expect the description field to always be a string
Description of user facing changes
Add-ons without descriptions can be correctly viewed in the add-on store
Description of development approach
return an empty string if there is no description for the add-on.
Testing strategy:
Manual testing
Known issues with pull request:
None
Change log entries:
N/A
Code Review Checklist: