Skip to content

Add-on store: handle description from manifest is None#15245

Merged
seanbudd merged 1 commit into
betafrom
fixupOptDesc
Aug 2, 2023
Merged

Add-on store: handle description from manifest is None#15245
seanbudd merged 1 commit into
betafrom
fixupOptDesc

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 2, 2023

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

The description fields in the manifest are optional, and default to None.
This is not handled by the add-on models correctly, which expect the description field to always be a string

Description of user facing changes

Add-ons without descriptions can be correctly viewed in the add-on store

Description of development approach

return an empty string if there is no description for the add-on.

Testing strategy:

Manual testing

Known issues with pull request:

None

Change log entries:

N/A

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner August 2, 2023 04:32
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team August 2, 2023 04:32
@seanbudd seanbudd added this to the 2023.2 milestone Aug 2, 2023
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit d9fecde090

@seanbudd seanbudd merged commit a0bae3e into beta Aug 2, 2023
@seanbudd seanbudd deleted the fixupOptDesc branch August 2, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants