Link to issue number:

Addresses issue introduced by pr #14524

Summary of the issue:

Reports from users that if a specifically configured braille display cannot be initialized on start-up, then the Braille category in the NVDA settings dialog is broken and does not show a valid braille driver (noBraille or otherwise).

Description of user facing changes

The Braille category in NVDA settings will continue to be usable if the configured Braille display cannot be initialized on start-up.

Description of development approach

In braille.handler.setDisplayByName if setting the display failed, the display is not set to NoBraille if the display was (not) already NoBraille. Previously this logic was incorrectly reversed.

Testing strategy:

• Set braille driver to something that does not exist.
• Restart NVDA.
• Try to open the Braille category in NVDA settings.

Known issues with pull request:

None known.

Change log entries:

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.