Conversation
Changes to handle #15150 Follow up to #14697, #14896, #15038, #15097, #15145 Summary of the issue: WASAPI usage is known to cause intermittent crashing in #15150. Generally, WASAPI code has not been proven to be stable. Due to this, it should not be enabled by default in 2023.2. WASAPI can be re-enabled by default once it is proven to be stable. Description of user facing changes Disable WASAPI by default, preventing intermittent crashing #15150 Description of development approach Turn the WASAPI checkbox into a feature flag, so that it can easily be re-enabled in future. Testing strategy: Manual testing Upgrading the profile: Test starting NVDA with the WASAPI config value set to "True/False" instead of a "enabled/disabled/default". Test the various controls related to WASAPI - ensure they are saved, applied and respected correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.