Skip to content

Add-on store: Fix up loading message#15186

Merged
seanbudd merged 1 commit into
betafrom
fixupFilterRest
Jul 25, 2023
Merged

Add-on store: Fix up loading message#15186
seanbudd merged 1 commit into
betafrom
fixupFilterRest

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 25, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #14975
Fixes #15184

Summary of the issue:

Sometimes the add-on store incorrectly reports "Loading add-ons" when it should report "No add-on selected".
This happens when no add-ons are found. When an add-on is found, the text is correctly replaced with the add-ons name.

When switching tabs, the add-on search filter should be reset.

Description of user facing changes

Fix bug where "No add-on selected" should be reported instead of "loading add-ons".

When switching tabs, the add-on search filter is now reset.

Description of development approach

Notify the details panel to update when the add-on list loading is complete. Previously, this would only refresh when an add-on was found.

Testing strategy:

Test STR in #14975 and #15184

Known issues with pull request:

None

Change log entries:

N/A

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner July 25, 2023 05:30
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team July 25, 2023 05:30
@seanbudd seanbudd added this to the 2023.2 milestone Jul 25, 2023
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 272ade8429

@seanbudd seanbudd merged commit 253ad28 into beta Jul 25, 2023
@seanbudd seanbudd deleted the fixupFilterRest branch July 25, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants