Add-on store: Fix up loading message#15186
Merged
Merged
Conversation
michaelDCurran
approved these changes
Jul 25, 2023
See test results for failed build of commit 272ade8429 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14975
Fixes #15184
Summary of the issue:
Sometimes the add-on store incorrectly reports "Loading add-ons" when it should report "No add-on selected".
This happens when no add-ons are found. When an add-on is found, the text is correctly replaced with the add-ons name.
When switching tabs, the add-on search filter should be reset.
Description of user facing changes
Fix bug where "No add-on selected" should be reported instead of "loading add-ons".
When switching tabs, the add-on search filter is now reset.
Description of development approach
Notify the details panel to update when the add-on list loading is complete. Previously, this would only refresh when an add-on was found.
Testing strategy:
Test STR in #14975 and #15184
Known issues with pull request:
None
Change log entries:
N/A
Code Review Checklist: