Fix 'flickUp' text review touch gesture#15171
Merged
Merged
Conversation
See test results for failed build of commit a6f9ab5bfc |
michaelDCurran
approved these changes
Jul 21, 2023
codeofdusk
reviewed
Jul 22, 2023
| resumeSayAllMode=sayAll.CURSOR.REVIEW, | ||
| category=SCRCAT_TEXTREVIEW, | ||
| gestures=("kb:NVDA+pageUp", "kb(laptop):NVDA+shift+pageUp", "ts(text):flickUp") | ||
| gestures=("kb:NVDA+pageUp", "kb(laptop):NVDA+shift+pageUp") |
Contributor
There was a problem hiding this comment.
Oops, looks like a bad copy/paste on my end. Sorry!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15127
Fix up of #14021
Summary of the issue:
#14021 accidentally overwrote the touch gesture to move to the previous line in text review mode.
These overwritten gestures were not documented in the user guide, and appear to be unintentional.
Description of user facing changes
Remove overwritten "flickUp" gestures.
Description of development approach
Remove overwritten "flickUp" gestures.
Testing strategy:
Test text review mode with touch gestures
Known issues with pull request:
None
Change log entries:
Fix bug causing text review "flick up" touch gesture to move pages rather than move to previous line. (#15127)
Code Review Checklist: