Add-on store: display author and add-on id in details#15160
Conversation
| model = detailsVM.model | ||
| inPublisher = isinstance(model, _AddonStoreModel) and term in model.publisher.casefold() | ||
| inAuthor = isinstance(model, _InstalledAddonModel) and term in model.author.casefold() | ||
| return ( |
There was a problem hiding this comment.
Could we also search for IDs since it is now a displayed information (and was already an information sometimes seen by user e.g. in the uninstall dialog boxes)?
Since the ID is often similar to the add-on's name in English, it may be especially useful for non-English speakers used though to know also English names of the add-ons.
Or maybe even better: for non-English users to be able to filter either on English add-on's name or non-English add-on's name. E.g. be able to filter on "Mise à Jour des Extensions" as well as on "Add-on Updater". If this is your choice, I will open a separate issue since it's beyond the scope of this PR.
There was a problem hiding this comment.
Searching via add-on ID has already been added just below in line 309
Link to issue number:
Raised in #14912 (comment)
Summary of the issue:
A user may wish to discover the internal ID of an add-on.
For an add-on installed from the datastore, both
publisherandauthorfields can be displayed.Description of user facing changes
Display the add-on ID in the details panel.
Show the "author" field for add-ons installed from the datastore.
Description of development approach
Testing strategy:
Tested viewing the details of internally and externally installed add-ons.
Known issues with pull request:
None
Change log entries:
N/A
Code Review Checklist: