Skip to content

Retain aliases lost in #15121#15151

Merged
seanbudd merged 2 commits into
masterfrom
addAliases
Jul 17, 2023
Merged

Retain aliases lost in #15121#15151
seanbudd merged 2 commits into
masterfrom
addAliases

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 17, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Follow up to #15121

Fixes #15142
Fixes #15141
Fixes #15148
Fixes #15147

Summary of the issue:

PR #15121 to fix #15120 had various unexpected side effects.
This is due to symbols that were previously star imported into gui/__init__.py being removed.
Add-ons and the vision enhancements core module relied on these symbols being imported.
While there was no API breaking changes, these changes affected over 30 add-ons

Description of user facing changes

Fix up issue with vision enhancement providers, such as opening the relevant settings panels.

Description of development approach

Add aliases for SettingsPanel, AutoSettingsMixin, _popupSettingsDialog in gui

Testing strategy:

Test importing aliases from python console

Known issues with pull request:

None

Change log entries:

N/A

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@XLTechie

XLTechie commented Jul 17, 2023 via email

Copy link
Copy Markdown
Collaborator

@seanbudd seanbudd merged commit c4ca763 into master Jul 17, 2023
@seanbudd seanbudd deleted the addAliases branch July 17, 2023 06:51
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment