Retain aliases lost in #15121#15151
Merged
Merged
Conversation
6 tasks
Collaborator
|
Thanks @seanbudd.
|
michaelDCurran
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up to #15121
Fixes #15142
Fixes #15141
Fixes #15148
Fixes #15147
Summary of the issue:
PR #15121 to fix #15120 had various unexpected side effects.
This is due to symbols that were previously star imported into
gui/__init__.pybeing removed.Add-ons and the vision enhancements core module relied on these symbols being imported.
While there was no API breaking changes, these changes affected over 30 add-ons
Description of user facing changes
Fix up issue with vision enhancement providers, such as opening the relevant settings panels.
Description of development approach
Add aliases for
SettingsPanel, AutoSettingsMixin, _popupSettingsDialoginguiTesting strategy:
Test importing aliases from python console
Known issues with pull request:
None
Change log entries:
N/A
Code Review Checklist: