Skip to content

Add-on store: fix bug with external installs#15140

Merged
seanbudd merged 1 commit into
masterfrom
fixExternalBug
Jul 14, 2023
Merged

Add-on store: fix bug with external installs#15140
seanbudd merged 1 commit into
masterfrom
fixExternalBug

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 14, 2023

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

The add-on store cache for an installed addon should be deleted in the following scenarios:

  • when removing an add-on
  • when installing an external version of an add-on

This was not reflected correctly in the code

Additionally, external add-ons were incorrectly grouped as stable add-ons in some cases

Description of user facing changes

Fix bug where add-on store cache would be incorrectly deleted or incorrectly retained in various scenarios.

Description of development approach

Delete add-on cache file when removing or updating an add-on from an external source.

Testing strategy:

Test updating various add-ons

Known issues with pull request:

None

Change log entries:

N/a

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner July 14, 2023 06:00
@seanbudd seanbudd requested a review from michaelDCurran July 14, 2023 06:00
@seanbudd seanbudd merged commit 48ca55d into master Jul 14, 2023
@seanbudd seanbudd deleted the fixExternalBug branch July 14, 2023 07:02
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants