Fix missing first SAPI5 utterance after silence#15129
Merged
Merged
Conversation
jcsteh
approved these changes
Jul 11, 2023
jcsteh
left a comment
Contributor
There was a problem hiding this comment.
Bizarre. I guess Windows thinks the SAPI5 thread is hung even though it's still processing messages? How is that possible? 😕
I can't see any problem with this. At worst, we won't return immediately for messages in the WM_APP range if an app hangs, but they'll still be cancellable by watchdog.
Member
|
I can confirm this is no longer a problem on my machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15082
Summary of the issue:
The first utterance after around 10 seconds of silence with a SAPI5 synth is not spoken.
Description of user facing changes
Issue does no longer occur.
Description of development approach
Since #14759 we are modifying some window messages in our process. This includes setting the SMTO_ABORTIFHUNG flag. I was able to pinpoint that setting this flag to a message of type WM_APP caused this particular issue with SAPI5. Therefore I excluded this range of messages (WM_APP through 0xBFFF).
Testing strategy:
Tested that NVDA with SAPI5 no longer stays silent when pressing down arrow on the desktop after more than 10 seconds of silence.
Known issues with pull request:
None known.
Change log entries:
None needed.
Code Review Checklist: