Add-on Store: Remove invalid cache file#15111
Merged
Merged
Conversation
See test results for failed build of commit e3556a1ea0 |
Collaborator
|
@seanbudd is this prevented from running in installer/temporary copies? I ask because I have installed the snapshot of this build. On the positive side, it solves the problem I reported in the referenced issue. However now I'm concerned that it removed the cache while the installer was running, which goes back to an older consideration. |
Member
Author
|
Fixed, thanks @XLTechie |
michaelDCurran
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15106
Summary of the issue:
If NVDA has an invalid add-on store cache file it can be safely deleted until a new cache is fetched.
Without deleting it, NVDA will start with an error until it is overwritten by browsing add-ons.
Description of user facing changes
If NVDA has invalid cache data for the add-on store, NVDA will log an exception then delete the invalid cache file.
Description of development approach
If NVDA has invalid cache data for the add-on store, NVDA will log an exception then delete the invalid cache file.
Testing strategy:
Test invalid cache file
Known issues with pull request:
None
Change log entries:
N/A
Code Review Checklist: