Skip to content

Fix context help in Add-on Store#15080

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:ctxHelp
Jul 2, 2023
Merged

Fix context help in Add-on Store#15080
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:ctxHelp

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

  • Calling context help in the add-on store while the focus is in "Other details" or on the tabs does not jump to the add-on store paragraph.
  • Context help on other GUI controls (add-ons list, action button) is not impacted by this issue since they have dedicated help targets.

Description of user facing changes

Context help works correctly in add-on store, i.e. jumps to the correct paragraph.

Description of development approach

Fix the anchor's name according to what is in the user guide.

Testing strategy:

Tested F1 with a portable version created from the snapshot generated by appVeyor (nvda_snapshot_pr15080-28549,7e72e668.exe) when the focus is in tabs, description field or other details.

Known issues with pull request:

None

Change log entries:

None (patching unreleased feature)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 30, 2023 22:54
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 30, 2023 22:54
@CyrilleB79 CyrilleB79 requested a review from seanbudd June 30, 2023 22:54

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @CyrilleB79

@seanbudd seanbudd merged commit 3a9a205 into nvaccess:master Jul 2, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jul 2, 2023
@CyrilleB79 CyrilleB79 deleted the ctxHelp branch July 3, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants