Conversation
Member
Author
|
@zstanecic can you please confirm that this build fixes your issue? |
michaelDCurran
approved these changes
Jun 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14750
Summary of the issue:
If a braille display is initialized, but then disconnected, the input gestures dialog cannot be opened.
Description of user facing changes
Description of development approach
As per handling in
scriptHandler, we must check the existence of braille handler display before fetching gestureMapnvda/source/scriptHandler.py
Line 97 in 7a9b40a
Testing strategy:
Known issues with pull request:
None
Change log entries:
N/A fixes regression?
Code Review Checklist: