Add-on store: fix UX when using high contrast themes#15026
Merged
Conversation
michaelDCurran
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15007
Summary of the issue:
NVDA sets the background colour for the details panel explicitly as white, and the text of the details explicitly as black.
This causes text to be hard to read during high contrast mode.
When high contrast mode is activated the background of text controls are correctly set to black, but the text color is also black.
Additionally, the details background is set to white, instead of black, like the text controls.
Instead, we should infer the background colour to match contrast modes.
Example image:

Description of user facing changes
High contrast themes works as expected for the add-on store dialog.

Description of development approach
Use the BG colour of text controls to set the background colour of the details panel.
Additionally, remove the code which makes the text explicitly black.
Testing strategy:
View the add-on store dialog without any contrast themes - and ensure it hasn't visually changed.
View the add-on store dialog with each contrast theme - and ensure it is visually as expected.
Known issues with pull request:
None
Change log entries:
N/a
Code Review Checklist: