Skip to content

Add-on store: fix UX when using high contrast themes#15026

Merged
seanbudd merged 1 commit into
masterfrom
fixContrast
Jun 19, 2023
Merged

Add-on store: fix UX when using high contrast themes#15026
seanbudd merged 1 commit into
masterfrom
fixContrast

Conversation

@seanbudd

@seanbudd seanbudd commented Jun 19, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15007

Summary of the issue:

NVDA sets the background colour for the details panel explicitly as white, and the text of the details explicitly as black.
This causes text to be hard to read during high contrast mode.
When high contrast mode is activated the background of text controls are correctly set to black, but the text color is also black.
Additionally, the details background is set to white, instead of black, like the text controls.
Instead, we should infer the background colour to match contrast modes.

Example image:
image

Description of user facing changes

High contrast themes works as expected for the add-on store dialog.
image

Description of development approach

Use the BG colour of text controls to set the background colour of the details panel.
Additionally, remove the code which makes the text explicitly black.

Testing strategy:

View the add-on store dialog without any contrast themes - and ensure it hasn't visually changed.

View the add-on store dialog with each contrast theme - and ensure it is visually as expected.

Known issues with pull request:

None

Change log entries:

N/a

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner June 19, 2023 05:44
@seanbudd seanbudd requested a review from michaelDCurran June 19, 2023 05:44
@seanbudd seanbudd merged commit 3d78d70 into master Jun 19, 2023
@seanbudd seanbudd deleted the fixContrast branch June 19, 2023 08:09
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA add-ons store: UI: Partial incompatibility with Windows High Contrast mode

3 participants