Add space between add-on list and External install button in the add-on store GUI#15009
Conversation
|
@k-kolev1985 could you please double check with this build and confirm that the visual layout is correct? |
|
Hello! I have reviewed the GUI for the add-on store and visually, there is indeed a gap between the list and buttons. However, there is a horizontal divider between the "Install from external source" button and the close button, and the distance between the "Install from external source" button and the divider is not equal to the distance between the list and the divider. Of course, this is not a significant issue. |
|
I can confirm the findings of @hwf1324. |
seanbudd
left a comment
There was a problem hiding this comment.
looks good to me, thanks @CyrilleB79
|
OK, I have now used the standard spacing of NVDA dialog boxes instead. @hwf1324 the window becomes as follows: Is it OK now? |
See test results for failed build of commit a99ffd5812 |
Excellent, it is now in a satisfactory state! In addition, I would like to put forth a few suggestions here. Perhaps I should open an issue? The default size of the add-on store upon opening may not necessarily need to be maximized. The "Include incompatible add-ons" checkbox is not aligned with the component to its left, but rather it is affixed to the top. The height of the detail information panel on the right-hand side should match that of the add-on list on the left-hand side, which may potentially address issue #15011 simultaneously. |
|
Yes please, open a new issue. |

Link to issue number:
Fixes #15008
Summary of the issue:
In the add-on store GUI, the add-on list and the "Install from external source" button are too close to each other.
Description of user facing changes
There is now more space between the add-ons list and the button.
Description of development approach
Added a spacer between the two controls in the sizer. I have use the hard-coded value 5 as done elsewhere in this dialog.
Testing strategy:
Known issues with pull request:
None.
Change log entries:
Not needed; fix on unrleased code.
Code Review Checklist: