Skip to content

Add space between add-on list and External install button in the add-on store GUI#15009

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:storeGuiSpacer
Jun 18, 2023
Merged

Add space between add-on list and External install button in the add-on store GUI#15009
seanbudd merged 3 commits into
nvaccess:masterfrom
CyrilleB79:storeGuiSpacer

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #15008

Summary of the issue:

In the add-on store GUI, the add-on list and the "Install from external source" button are too close to each other.

Description of user facing changes

There is now more space between the add-ons list and the button.

Description of development approach

Added a spacer between the two controls in the sizer. I have use the hard-coded value 5 as done elsewhere in this dialog.

Testing strategy:

  • Checked visually that there is more space.
  • Given my low vision, ask confirmation to someone else. Maybe @k-kolev1985 or @seanbudd can check once the appVeyor build is ready?

Known issues with pull request:

None.

Change log entries:

Not needed; fix on unrleased code.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

@k-kolev1985 could you please double check with this build and confirm that the visual layout is correct?

@hwf1324

hwf1324 commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Hello!

I have reviewed the GUI for the add-on store and visually, there is indeed a gap between the list and buttons. However, there is a horizontal divider between the "Install from external source" button and the close button, and the distance between the "Install from external source" button and the divider is not equal to the distance between the list and the divider. Of course, this is not a significant issue.

@k-kolev1985

Copy link
Copy Markdown
Contributor

I can confirm the findings of @hwf1324.
Now it is better - there is a visual gap between the list and the button below it.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @CyrilleB79

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

OK, I have now used the standard spacing of NVDA dialog boxes instead.

@hwf1324 the window becomes as follows:
addonStore

Is it OK now?

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit a99ffd5812

@hwf1324

hwf1324 commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Is it OK now?

Excellent, it is now in a satisfactory state!

In addition, I would like to put forth a few suggestions here. Perhaps I should open an issue?

The default size of the add-on store upon opening may not necessarily need to be maximized.

The "Include incompatible add-ons" checkbox is not aligned with the component to its left, but rather it is affixed to the top.

The height of the detail information panel on the right-hand side should match that of the add-on list on the left-hand side, which may potentially address issue #15011 simultaneously.

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Yes please, open a new issue.

@CyrilleB79 CyrilleB79 requested a review from seanbudd June 16, 2023 14:34
@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 16, 2023 14:34
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 16, 2023 14:34
@seanbudd seanbudd merged commit 4a1e840 into nvaccess:master Jun 18, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 18, 2023
@CyrilleB79 CyrilleB79 deleted the storeGuiSpacer branch June 30, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA add-ons store: UI: "Install from external source" button is too close to the list control above it

6 participants